Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/9947 Add str method to datamodule #20301

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/9947 Add str method to datamodule #20301

wants to merge 4 commits into from

Commits on Sep 25, 2024

  1. Add feature implementation to datamodule for str method 

    First implementation scetch
    @MrWhatZitToYaa
    MrWhatZitToYaa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28ee099 View commit details
    Browse the repository at this point in the history

  2. Removed list / tuple case for datamodule str method

    @MrWhatZitToYaa
    MrWhatZitToYaa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c4038e3 View commit details
    Browse the repository at this point in the history

  3. Added test cases for DataModule string function 

    Added alternative Boring Data Module implementations
Added test cases for all possible options
Added additional check for NotImplementedError in string function of DataModule
    @MrWhatZitToYaa
    MrWhatZitToYaa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a58b3d7 View commit details
    Browse the repository at this point in the history

  4. Reverted accidental changes in DataModule

    @MrWhatZitToYaa
    MrWhatZitToYaa committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b2e9c89 View commit details
    Browse the repository at this point in the history