Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect evals even when samples=0 #94

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Respect evals even when samples=0 #94

merged 2 commits into from
Apr 6, 2024

Conversation

LilithHafner
Copy link
Owner

@LilithHafner LilithHafner commented Apr 6, 2024 •
edited
Loading

Fixes broken test

@LilithHafner
Copy link
Owner Author

LilithHafner commented Apr 6, 2024 •
edited
Loading

This is was a breaking change because samples=0 is documented:

• samples::Integer Maximum number of samples to take. Defaults to unlimited and cannot be specified without also specifying evals. Specifying samples = 0
will cause @be to run the warmup sample only and return that sample.

@LilithHafner LilithHafner changed the title Disallow samples=0 Respect evals even when samples=0 Apr 6, 2024
@LilithHafner LilithHafner merged commit cb6e62c into main Apr 6, 2024
15 checks passed
@LilithHafner LilithHafner deleted the lh/nonzero-samples branch April 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LilithHafner