feat(extensionPoints): do not store extension instances anywhere

LinWanCen · Nov 4, 2024 · 3b32f05 · 3b32f05
1 parent f8ba906
commit 3b32f05
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/src/main/kotlin/com/github/linwancen/plugin/graph/parser/Parser.kt b/src/main/kotlin/com/github/linwancen/plugin/graph/parser/Parser.kt
@@ -22,30 +22,30 @@ abstract class Parser {
     companion object {
         private val log = LoggerFactory.getLogger(this::class.java)
 
-        @JvmStatic
-        val SERVICES = mutableMapOf<String, Parser>()
-
-        init {
+        fun parserMutableMap(): MutableMap<String, Parser> {
             val epn: ExtensionPointName<Parser> = ExtensionPointName.create("com.github.linwancen.drawgraph.parser")
-            val extensionList = epn.extensionList
-            log.info("load graph parser epn {}", extensionList)
-            extensionList.forEach {
+            val parserList = epn.extensionList
+            log.info("load graph parser epn {}", parserList)
+            val parserMap = mutableMapOf<String, Parser>()
+            parserList.forEach {
                 log.info("load graph parser {} -> {}", it.id(), it)
-                SERVICES[it.id()] = it
+                parserMap[it.id()] = it
             }
+            return parserMap
         }
 
         /**
          * need DumbService.getInstance(project).runReadActionInSmartMo
          */
         @JvmStatic
         fun src(project: Project, relData: RelData, files: Array<out VirtualFile>) {
+            val parserMap = parserMutableMap()
             // not get child dir easy select by shift skip dir
             for (file in files) {
                 val psiFile = PsiManager.getInstance(project).findFile(file) ?: continue
                 var language = psiFile.language
                 language.baseLanguage?.let { language = it }
-                val usageService = SERVICES[language.id] ?: continue
+                val usageService = parserMap[language.id] ?: continue
                 // not one by one because pom.xml find all files
                 usageService.srcImpl(project, relData, files)
                 // only one lang srcImpl all and return
@@ -58,9 +58,10 @@ abstract class Parser {
          */
         @JvmStatic
         fun call(project: Project, relData: RelData, psiElement: PsiElement) {
+            val parserMap = parserMutableMap()
             var language = psiElement.language
             language.baseLanguage?.let { language = it }
-            val usageService = SERVICES[language.id] ?: return
+            val usageService = parserMap[language.id] ?: return
             usageService.callImpl(project, relData, psiElement)
         }
 
@@ -69,7 +70,9 @@ abstract class Parser {
          */
         @JvmStatic
         fun nameToElement(project: Project, name: String): PsiElement? {
-            for (it in SERVICES.values) {
+            val epn: ExtensionPointName<Parser> = ExtensionPointName.create("com.github.linwancen.drawgraph.parser")
+            val parserList = epn.extensionList
+            for (it in parserList) {
                 val element = it.nameToElementImpl(project, name)
                 if (element != null) {
                     return element