Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot read slice of undefined Error #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrew1931
Copy link

when I have config like this:

assets: {
    from: [
        'node_modules/[some-library-1]/filename',
        'node_modules/[some-library-2]/filename',
    ],
    to: ['dist']
},

I have an error "Cannot read slice of undefined". With this "continue" statement from my commit all the files are being copied without any errors.

PS: I don't see why in esbuild-plugin-copy.ts file you call "copyOperationHandler" for every item in "to" array in a loop for every item in "from" array and then inside "copyOperationHandler" function you run a loop for "from" paths again.
There won't be this error without this inner loop inside "copyOperationHandler".
But I believe there is a reason for this logic:) cheers

Copy link

changeset-bot bot commented Apr 3, 2024

⚠️ No Changeset found

Latest commit: 124ed85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant