Skip to content

Commit

Permalink
Only discard the roaming icon if we're not roaming anymore.
Browse files Browse the repository at this point in the history
  Ignore data roaming toggle because it shouldn't have impact on whether
  we show the indicator or not.

Change-Id: I445c1005a935eaca9d0a132d5a5a7fd214b300d0
(cherry picked from commit 682198e)
  • Loading branch information
Adnan authored and Brint E. Kriebel committed Dec 16, 2014
1 parent 15e59e7 commit 9bb2da1
Showing 1 changed file with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -663,11 +663,6 @@ private final void updateDataNetType(int subscription) {
// DSDS case: Data is active only on DDS. Clear the icon for NON-DDS
int dataSub = MSimTelephonyManager.getDefault().getPreferredDataSubscription();

// Clear roaming if we're always showing an indicator
if (SystemProperties.getBoolean("ro.config.always_show_roaming", false)) {
mMSimDataRoamIconId[subscription] = 0;
}

if (subscription != dataSub) {
if (DEBUG) {
Slog.d(TAG,"updateDataNetType: SUB" + subscription
Expand Down Expand Up @@ -845,6 +840,8 @@ private final void updateDataNetType(int subscription) {
}
if (subscription == dataSub) mQSDataTypeIconId =
TelephonyIcons.QS_DATA_R[mInetCondition];
} else if (!mPhone.isNetworkRoaming(subscription)) {
mMSimDataRoamIconId[subscription] = 0;
}
}

Expand Down Expand Up @@ -1058,11 +1055,6 @@ protected void refreshViews(int subscription) {
final boolean emergencyOnly = isEmergencyOnly(); // All sims are emergency only
int dataSub = MSimTelephonyManager.getDefault().getPreferredDataSubscription();

// Clear roaming if we're always showing an indicator
if (SystemProperties.getBoolean("ro.config.always_show_roaming", false)) {
mMSimDataRoamIconId[subscription] = 0;
}

if (DEBUG) {
Slog.d(TAG,"refreshViews subscription =" + subscription + "mMSimDataConnected ="
+ mMSimDataConnected[subscription]);
Expand Down Expand Up @@ -1243,6 +1235,8 @@ else if (!mMSimDataConnected[subscription] && !mWifiConnected && !mBluetoothTeth
}
if (subscription == dataSub) mQSDataTypeIconId =
TelephonyIcons.QS_DATA_R[mInetCondition];
} else if (!mPhone.isNetworkRoaming(subscription)) {
mMSimDataRoamIconId[subscription] = 0;
}
}

Expand Down

0 comments on commit 9bb2da1

Please sign in to comment.