Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. We are using your library in our design system. And
portal-vue
appears in bundle even when we are not importing dependent components. I checked youresm
bundle withagadoo
. Seems like your package has problems with tree-shaking.So I added
#__PURE__
annotations for everyVue.extend()
expression. I think it helped. At leastagadoo
thinks so.Also I added
size-limit
package to test tree-shaking and import cost.Before:
After:
There are 2 new commands in
package.json
:agadoo
size-limit
and check bundle sizeI will be glad if you merge this PR or fix it by yourself.