Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify debian/configure by moving constant values to where they are used #1963

Conversation

petterreinholdtsen
Copy link
Collaborator

This reduce the work done by debian/configure and make it easier to see
exactly which settings are configured.

… used

This reduce the work done by debian/configure and make it easier to see
exactly which settings are configured.
@smoe
Copy link
Contributor

smoe commented Aug 25, 2022

@SebKuzminsky You know better than me if this simplification loses anything.

@smoe
Copy link
Contributor

smoe commented Sep 5, 2022

Maybe I was not clear enough in my previous comment: I think this is a fine contribution and if I am not missing something then this should be accepted.

@andypugh
Copy link
Collaborator

This seems to commit us to never supporting kernel-mode RTAI again.
Are we sure we want to do that?

@SebKuzminsky
Copy link
Collaborator

I am opposed to this PR, at least for now. I still maintain hope that we can reintroduce kernel-mode RTAI support in the future.

If @jepler's uspace lxrt work proves to be as performant as kernel-mode RTAI on a wide and representative range of hardware, I may soften my stance.

@petterreinholdtsen
Copy link
Collaborator Author

OK. It was just a stopgap change before updating to Debian profile
based build like proposed in #1835. When using profiles, we drop
debian/configure completely.

I believe it is a waste to have lots of unused variables in
debian/configure, and believe that given the fact that everything is
visible in the git history, those fixing RTAI can reintroduce these
variables any any time in the future, but se no point in using more time
on this cleanup.

@petterreinholdtsen
Copy link
Collaborator Author

petterreinholdtsen commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants