fix: fix default destructor

LiteLDev · Jan 24, 2024 · a491566 · a491566
1 parent 503e735
commit a491566
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Plugin.cpp b/src/Plugin.cpp
@@ -4,6 +4,8 @@
 
 namespace plugin {
 
+Plugin::~Plugin() = default;
+
 static std::unique_ptr<Plugin> plugin{};
 
 Plugin& Plugin::getInstance() { return *plugin; }

diff --git a/src/Plugin.h b/src/Plugin.h
@@ -13,11 +13,11 @@ class Plugin {
     Plugin& operator=(Plugin&&)      = delete;
     Plugin& operator=(const Plugin&) = delete;
 
-    ~Plugin() = default;
+    ~Plugin(); // NOLINT(performance-trivially-destructible)
 
     static Plugin& getInstance();
 
-    ll::plugin::NativePlugin& getSelf() const;
+    [[nodiscard]] ll::plugin::NativePlugin& getSelf() const;
 
     /// @return True if the plugin is enabled successfully.
     bool enable();