Skip to content

Commit

Permalink
fix #40 tempory file will closed after request was sent
Browse files Browse the repository at this point in the history
  • Loading branch information
zyxkad committed Mar 3, 2024
1 parent 4d6132a commit e5cd4d1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -1037,12 +1037,12 @@ func (cr *Cluster) syncFiles(ctx context.Context, files []FileInfo, heavyCheck b
defer srcFd.Close()
for _, target := range f.targets {
if _, err = srcFd.Seek(0, io.SeekStart); err != nil {
log.Errorf("Could not seek file %q to start: %v", path, err)
log.Errorf("Cannot seek file %q to start: %v", path, err)
continue
}
err := target.Create(f.Hash, srcFd)
if err != nil {
log.Errorf("Could not create %s/%s: %v", target.String(), f.Hash, err)
log.Errorf("Cannot create %s/%s: %v", target.String(), f.Hash, err)
continue
}
}
Expand Down Expand Up @@ -1350,11 +1350,11 @@ func (cr *Cluster) DownloadFile(ctx context.Context, hash string) (err error) {

for _, target := range cr.storages {
if _, err = srcFd.Seek(0, io.SeekStart); err != nil {
log.Errorf("Could not seek file %q: %v", path, err)
log.Errorf("Cannot seek file %q: %v", path, err)
return
}
if err := target.Create(hash, srcFd); err != nil {
log.Errorf("Could not create %q: %v", target.String(), err)
log.Errorf("Cannot create %q: %v", target.String(), err)
continue
}
}
Expand Down
2 changes: 1 addition & 1 deletion storage/storage_webdav.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (s *WebDavStorage) putFile(path string, r io.ReadSeeker) error {
}
log.Debugf("Putting %q", target)

req, err := http.NewRequestWithContext(context.TODO(), http.MethodPut, target, r)
req, err := http.NewRequestWithContext(context.TODO(), http.MethodPut, target, io.NopCloser(r))
if err != nil {
return err
}
Expand Down

0 comments on commit e5cd4d1

Please sign in to comment.