Allow deleting multiple records of a model at once #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving this up to the top-level allows us to write code that abstracts over all Jack models and supports deletes.
roshan
force-pushed
the
allow-multi-deletes
branch
from
9246e90 to
8500508
Compare
tuliren
reviewed
Apr 29, 2019
| assertTrue(posts.find(Arrays.asList(post1, post2)).isEmpty()); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Nitpick: extra newline here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this up to the top-level allows us to write code that abstracts
over all Jack models and supports deletes for multiple IDs. This
seems reasonable since we do have
delete(long id).