Fix issue of type i64 in Rust not properly getting converted to BigInt in TypeScript #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I did notice that recent wasm-bindgen versions apparently changed the way number types are represented, but didn't yet get to fixing that, so thank you. Can you change it for U64 as well? Other than that, this looks good. |
Done! |
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling
livesplit-coreto WASM TypeScript from Rust, a compilation error is produced in the resultingindex.tsfile for thewholeSecondsfunction. The return type for this function is incorrectly set tonumberinstead ofBigInt, this PR corrects that problem by modifying thewasm_bindgen.rsfile appropriately.Admittedly, I don't know much about Rust so I could be handling this wrong, but I believe this is the correct fix and it seems to be working correctly for me. Let me know if I need to make any additional changes to get this working properly again 👍