Remove black points in the generated colored point cloud #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code will generate black points if their RGB values are zero as they are only registered in the "cloud" PointCloud, but isn't the intention of the following snippet: ([lines 221-223](https://github.com/Livox-SDK/livox_camera_lidar_calibration/blob/27f9e6c8a1eda3326b7673da418e6d7112559c2f/src/color_lidar_display.cpp#L221-L223)) ``` if (RGB[0] == 0 && RGB[1] == 0 && RGB[2] == 0) { continue; } ``` to exclude the points in the point cloud that has no colour correspondence in order not to visualize it? If my assumption is correct about the real intention, then just setting the xyz coordinates after the condition will fix that small bug. Thank you very much for your great package, it is really cool and works pretty good, but had some hard time with detecting the corners in the point cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will generate black points if their RGB values are zero as they are only registered in the "cloud" PointCloud, but isn't the intention of the following snippet: (lines 221-223)
to exclude the points in the point cloud that has no colour correspondence in order not to visualize it? If my assumption is correct about the real intention, then just setting the xyz coordinates after the condition will fix that small bug.
Thank you very much for your great package, it is really cool and works pretty good, but had some hard time with detecting the corners in the point cloud.