Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(ui): modify action for collections with no known id #266

Conversation

ReenigneArcher
Copy link
Member

Description

Fixes issue url for items with no known ID.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #266 (e4e2c1b) into master (35d5185) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   69.68%   69.68%           
=======================================
  Files          12       12           
  Lines         983      983           
=======================================
  Hits          685      685           
  Misses        298      298           
Flag Coverage Δ
Linux 69.68% <100.00%> (ø)
Windows ?
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/webapp.py 65.45% <100.00%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-modify-action-for-collections-with-no-known-id branch from 77e725e to e4e2c1b Compare December 9, 2023 04:05
@ReenigneArcher ReenigneArcher merged commit f6cdb09 into master Dec 9, 2023
@ReenigneArcher ReenigneArcher deleted the fix(ui)-modify-action-for-collections-with-no-known-id branch December 9, 2023 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Collections show up in Web UI
1 participant