Basic check for qdrant existence #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apepkuss @alabulei1 Please review this PR and let me know if anything needs changing. |
|
I don't understand? Why is the build failing? |
|
Try the following two commands to see if there's any error/warning in your code: cargo +nightly fmt --all -- --check
cargo +nightly clippy --target wasm32-wasi -- -D warnings |
fixed unused import warning on hyper imports
following clippy's suggestions
clippy changes
clippy changes
clippy changes
|
@apepkuss Fixed them! I had no idea we were using clippy. |
|
@suryyyansh Please resolve the conflicts. Thanks! |
|
@apepkuss Please review the changes. The force pushes were because I accidentally merged my search-api branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no check for whether the qdrant service is running when running the server. This PR adds a simple check to prevent the server from running without an active service at the specified qdrant port and address.