Remove incorrect spanned quote usage #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokathor
added
the
proc-macros
danielhenrymantilla
approved these changes
Oct 19, 2024
|
may take me a bit to publish this but thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quote_spannedshould be used for associatingBox::new(#init)with theinitspan, for example. This crate is associating a lot of the returned tokens with the input tokens, which breaks clippy's "are these tokens from a proc macro" checks, which leads to issues like rust-lang/rust-clippy#13349 which are unsolvable from our end (to my knowledge).This PR swaps with normal quote, and adds a test to make sure that none of the
allowattributes get associated with input tokens to prevent the specific clippy issue from reappearing.