Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-580: Custom analyzer rule for parameter and variable name styling #42

Merged
merged 63 commits into from
Jun 30, 2024
Merged

OSOE-580: Custom analyzer rule for parameter and variable name styling #42

merged 63 commits into from
Jun 30, 2024

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented Jun 12, 2024 •
edited by jira bot
Loading

OSOE-580
Fixes #31

@BenedekFarkas
New cmdlet Measure-VariableNameStyling can determine whether paramete…
449d092 
…r names use the correct casing/styling
@BenedekFarkas
Updating Measure-VariableNameStyling with checks on variables against…
eccc851 
… automatic variables, parameters and general casing
@BenedekFarkas
Renaming cmdlet to Measure-VariableNameCasing
79814fb
@BenedekFarkas
Fixing that automatic variables in a Param block shouldn't be treated…
c5c1e1b 
… as a parameter
@BenedekFarkas
Minor improvement in Measure-VariableNameCasing for files with multip…
9618f9e 
…le functions
@BenedekFarkas
Merge branch 'dev' into issue/OSOE-580
f106d3b
@BenedekFarkas
Updating rule IDs
bb8ebaa
@BenedekFarkas
Checking out the issue branch in static-code-analysis
5007d4a
@BenedekFarkas
Really using the issue branch version of PS Analysis
56110be
@BenedekFarkas
Fixing PSUseParameterNameDeclaredCasing in Measure-VariableNameCasing
2305938
@BenedekFarkas
Updating Measure-VariableNameCasing to handle inline parameter lists too
8d21496
@BenedekFarkas
Looking for variable tokens inside the whole file or function body
221617e
@BenedekFarkas
Fixing that finding an automatic variable should prevent processing o…
c1e9788 
…ther rules
@BenedekFarkas
Fixing that parenthesis depth should take the AtParen and DollarParen…
59864df 
… tokens into account too
@BenedekFarkas
Displaying the $ character in analyzer messages
5ed2569
@BenedekFarkas
Skipping path-like expressions, such as $Env:SOMETHING
a3d913e
@BenedekFarkas
Completing the list of automatic variables
162c723
@BenedekFarkas
Adding/updating documentation
4288b10
@BenedekFarkas
Upgrading projects to net8.0 target framework
850fbee
@BenedekFarkas
Updating Violate-Analyzers to test warnings in Measure-VariableNameCa…
4bd0da5 
…sing
@BenedekFarkas
Updating test solution to use the beta release
a59a12d
@BenedekFarkas
Fixing typo
dceb258
@BenedekFarkas
Refactoring Measure-VariableNameCasing to work with the Abstract Synt…
6cdf214 
…ax Tree, step 1: PSUseCorrectAutomaticVariableNameCasing
@BenedekFarkas
A bit of code styling
b416050
@BenedekFarkas
Updating AstFunctions with code styling and mandatory attribute for p…
7e73c10 
…arameters
@BenedekFarkas
Updating comments, fixing that finding certain violations should cont…
2967ef6 
…inue the loop and adding the rest of the warnings
@BenedekFarkas
A bit of refactoring from ForEach-Object to foreach, to rely less on …
22f00e0 
…$PSItem
@BenedekFarkas
Fixing that Measure-VariableNameCasing should only care about the who…
6fb22a4 
…le file and shouldn't analyze individual functions
@BenedekFarkas
Adding useful instructions to the description
86c14f4
@BenedekFarkas
Fixing the message of PSUseParameterNameDeclaredCasing
8b7bdb6
@BenedekFarkas
Fixing that static-code-analysis-this-repo should use the issue branc…
64a05a0 
…h version of static-code-analysis
@BenedekFarkas
Adding support to handle variable names surrounded by braces
487e4c0
@BenedekFarkas
Dropping support for variable expressions enclosed in braces for now,…
45d7cb3 
… until everything else works as expected
@BenedekFarkas
Updating AstFunctions not to trip spell checking
6e10a7b
@BenedekFarkas
Updating warning messages and expected code analysis errors
77b5527
@BenedekFarkas
Fixing the detection of path-like expressions
3b48ccd
@BenedekFarkas
Updating comments and formatting
84985f9
@BenedekFarkas
Adding support for braced variables when checking against automatic v…
35a02f5 
…ariables and parameters
@BenedekFarkas
Standardizing correction and warning messages
c431133
@BenedekFarkas
Adding PSAvoidUsingUnnecessaryBracesInVariableNames warning
c5f94b7
@BenedekFarkas
Updating description
2655b3f
@BenedekFarkas
Adding separate parameter to Violate-Analyzers that raises PSAvoidUsi…
395a51f 
…ngUnnecessaryBracesInVariableNames
@BenedekFarkas
Renaming analyzer module to Measure-VariableNameFormat
7aaa632
@BenedekFarkas
Restoring the expected list of analyzer warnings for the NuGet packag…
6c7be57 
…e, because the package hasn't been updated yet, duh
@BenedekFarkas
Re-adding the expected warnings for the NuGet pacakge
b6f130b
@BenedekFarkas
Skip scoped variables and path-like expressions, regardless of braces…
fa6bdcb 
… or not
@BenedekFarkas
Disabling test-analysis-failure on the NuGet solution for now
73f16b9
@BenedekFarkas
Updating NuGet package version and the list of expected warnings
0421cc4
sarahelsaig
sarahelsaig requested changes Jun 25, 2024
View reviewed changes
Lombiq.Analyzers.PowerShell/Rules/AstFunctions.ps1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/AstFunctions.ps1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-LineContinuation/Measure-LineContinuation.psm1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-VariableNameFormat/Measure-VariableNameFormat.psm1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-VariableNameFormat/Measure-VariableNameFormat.psm1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-VariableNameFormat/Measure-VariableNameFormat.psm1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-VariableNameFormat/Measure-VariableNameFormat.psm1 Outdated Show resolved Hide resolved
Lombiq.Analyzers.PowerShell/Rules/Measure-VariableNameFormat/Measure-VariableNameFormat.psm1 Outdated Show resolved Hide resolved
@sarahelsaig sarahelsaig merged commit e6571d7 into dev Jun 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom analyzer rule for parameter and variable name styling (OSOE-580)
2 participants
@BenedekFarkas @sarahelsaig