Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTO] Newer architecture with a lot of fixes #2

Merged
merged 13 commits into from
Apr 5, 2024

Conversation

KostLinux
Copy link
Member

@KostLinux KostLinux commented Apr 4, 2024

Changes

  • Moved HTTP Router and routes to middleware
  • Moved handlers to separate folder
  • Made architectural picture, how the code will work
  • Moved PostgreSQL Envs to Config

Architecture

image

@KostLinux KostLinux added the enhancement New feature or request label Apr 4, 2024
@KostLinux KostLinux self-assigned this Apr 4, 2024
@KostLinux KostLinux marked this pull request as ready for review April 4, 2024 21:59
@KostLinux KostLinux requested a review from Matrix278 April 4, 2024 21:59
Copy link
Member

@Matrix278 Matrix278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen it here in changes, so I still think it misses the New containers and interfaces to initialize the services.

config/env_config.go Outdated Show resolved Hide resolved
handlers/api_handlers.go Outdated Show resolved Hide resolved
@KostLinux
Copy link
Member Author

I haven't seen it here in changes, so I still think it misses the New containers and interfaces to initialize the services.

I've read about interfaces and containers, but i don't see where i can use them. Interfaces basically say which methods the object should have - Effective Go. You can take a look for a good example here.

I don't know what do you mean by "containers".

@KostLinux KostLinux requested a review from Matrix278 April 5, 2024 19:56
@Matrix278
Copy link
Member

I haven't seen it here in changes, so I still think it misses the New containers and interfaces to initialize the services.

I've read about interfaces and containers, but i don't see where i can use them. Interfaces basically say which methods the object should have - Effective Go. You can take a look for a good example here.

I don't know what do you mean by "containers".

Actually, they were named constructors.

@KostLinux KostLinux merged commit 4794507 into master Apr 5, 2024
4 checks passed
@KostLinux KostLinux deleted the refactor/newer-architecture-with-fixes branch April 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants