Miscellaneous Fixes #1220
Open
Miscellaneous Fixes #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CBroz1
approved these changes
Feb 11, 2025
| warnings.warn( | ||
| f"Multiple ElectricalSeries objects found in: {nwb_file_abspath}\n\t" | ||
| + f"Inserting only first entry in {self.full_table_name}\n\t" | ||
| + "See issue #396 for more details." |
There was a problem hiding this comment.
Just making a note that this PR won't resolve #396 - it looks like more work would need to be done to either add a part table or concatenate these objects
There was a problem hiding this comment.
Correct, this PR just solves the case where there's non ElectricalSeries objects in acquisition
| @@ -39,9 +39,9 @@ def add_member_team(common_lab, add_admin): | |||
| last_name="Basic", | |||
| ), | |||
| dict( | |||
| lab_member_name="This Loner", | |||
| lab_member_name="This Loner", # codespell:ignore loner | |||
There was a problem hiding this comment.
I don't think this value is ever read, so I think I'd just change this to an accepted word. Maybe Solo? Low prioroty
Co-authored-by: Chris Broz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Probe.insert_from_nwbfiile()defineprobe_idfromprobe_descriptionrather thanprobe_typeProbeTypeandProbeElectrodeGroup.insert_from_nwbfile()to account for the changeRaw.insert_from_nwbfile()to work when non-ElectricalSeries objects are in nwb.acquisitionChecklist:
CITATION.cffaltersnippet for release notes.CHANGELOG.mdwith PR number and description.