Curtains! #40
Merged
Curtains! #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gegy
approved these changes
Oct 4, 2023
Closed
|
A friend of mine who is a muuuch better artist volunteered to draw something a bit nicer! Will hold on to this and see what he comes up with :) |
itsbazke
force-pushed
the
curtain-block
branch
from
424e6c9
to
24c7df4
Compare
|
@MartinNilsson how are we with this? |
My friend still didn't have time to fix the textures, but we could merge it right now and just update them later? |
|
Yeah I'm happy to merge now and update later. Then builders can get them in-world! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #35
Blocks light! You can walk through them! Fancy!
Texture could use some improvement, I'll see what I can do about that. But at least there is code!
It is basically a retextured glass pane that blocks light and has no collision. The blockstates were a mess to write in code so I took inspiration from
Infertile Vineand used some json from vanilla (I took it from 1.20.1.jar and changed it, can we do that?).Screenshots and videos don't really do it justice, its not that dark. Second image is mspaint hand stitched textures so you have to use some imagination (its somewhere in between)!