forked from conductor-oss/conductor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/llainez update javax deps #2
Open
LuisLainez
wants to merge
23
commits into
main
Choose a base branch
from
issue/llainez-UpdateJavaxDeps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered
Current Status
Struggling with the parsing into a ClientResponse - it keeps trying to deserialize the element as a ClientResponse, but that’s not right.
The hard code is getForEntity
ERROR com.netflix.conductor.client.http.ClientBase [] - Unable to invoke Conductor API with uri: http://localhost:8080/api/workflow/d045c33f-9728-4702-b0b9-bf868c01c75f?includeTasks=true, runtime exception occurred
jakarta.ws.rs.client.ResponseProcessingException:
com.fasterxml.jackson.databind.exc.InvalidDefinitionException:
Cannot construct instance of org.glassfish.jersey.client.ClientResponse
(no Creators, like default constructor, exist):
cannot deserialize from Object value (no delegate- or property-based Creator)
Journal
We deleted body from the delete request. This is because body is not really accepted in delete requests and will even be rejected sometimes.
We use ClientRequestFilter in the conductor-oss client as it’s for the client side: https://stackoverflow.com/questions/27578134/clientrequestfilter-vs-containerrequestfilter/27578248#27578248 - and register them via register https://docs.oracle.com/javaee/7/tutorial/jaxrs-client003.htm
We had to change jackson to
com.fasterxml.jackson.jakarta.rs:jackson-jakarta-rs-json-provider
as
com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider
uses the javax.ws. namespace instead of Jakarta and new Jersey doesnt like that
As we as upgrading
implementation "com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.0"
to the same version of Jackson.
webResourceBuilder no longer allows null as responseType, so I had to get the null as property type off the calls
webResourceBuilder.post(Entity.json(request), null) → webResourceBuilder.post(Entity.json(request))
I had to add
implementation "jakarta.ws.rs:jakarta.ws.rs-api:${revJAXRS}"
implementation 'jakarta.platform:jakarta.jakartaee-api:10.0.0' //Needed to jakarta.ws.rs-api
to common build.gradle because it is where the object mapper to read the tasks as ClientResponse, via Jersey, and it was failing ‘cause it uses MultiMap that is an abstract class and can’t initialize it.
I had to change the calls to ‘put’ with null requests as PUT does not accept a null entity.
WIP
Cleanup the JsonModule that introduces the changes for MultiMap + clean dependencies
Clean up the UniformInterfaceException that is not from Jersey
https://stackoverflow.com/questions/32042944/upgrading-from-jersey-client-1-x-to-jersey-client-2-x
https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/client.html
https://gist.github.com/aphexmunky/11399575
https://stackoverflow.com/questions/67013351/convert-jersey-1-x-client-to-jersey-2-x-client
https://stackoverflow.com/questions/53843533/clienthandlerexception-jersey
https://stackoverflow.com/questions/42468133/registering-jacksonjsonprovider-with-objectmapper-javatimemodule-to-jersey-2-c
https://stackoverflow.com/questions/32042944/upgrading-from-jersey-client-1-x-to-jersey-client-2-x