Skip to content

Commit

Permalink
Remove tests for old Selenium and PHP versions
Browse files Browse the repository at this point in the history
  • Loading branch information
justafish committed Dec 13, 2023
1 parent cfdf890 commit c15694b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
11 changes: 3 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
selenium: ['2.53.1', 'latest']
php: [ '8.1', '8.2', '8.3' ]
selenium: ['latest']
fail-fast: false

steps:
Expand Down Expand Up @@ -81,12 +81,7 @@ jobs:
while ! nc -z localhost 8002 </dev/null; do echo Waiting for PHP server to start...; sleep 1; done
- name: Run tests
run: |
if [ "${{ matrix.selenium }}" == "latest" ]; then
DRIVER_URL="http://localhost:4444" ./vendor/bin/phpunit -v --coverage-clover=coverage.xml
else
./vendor/bin/phpunit -v --coverage-clover=coverage.xml
fi
run: ./vendor/bin/phpunit -v --coverage-clover=coverage.xml

- name: Upload coverage
uses: codecov/codecov-action@v2
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<!--<server name="WEB_FIXTURES_BROWSER" value="firefox"/>-->

<!-- where driver will connect to -->
<!-- <server name="DRIVER_URL" value="http://localhost:4444/wd/hub" /> -->
<!-- <server name="DRIVER_URL" value=""http://localhost:4444" /> -->

<!-- where DocumentRoot of 'Test Machine' is mounted to on 'Driver Machine' (only if these are 2 different machines) -->
<!--server name="DRIVER_MACHINE_BASE_PATH" value="" /-->
Expand Down
2 changes: 1 addition & 1 deletion tests/Selenium2Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static function getInstance(): self
public function createDriver(): DriverInterface
{
$browser = getenv('WEB_FIXTURES_BROWSER') ?: 'firefox';
$seleniumHost = !empty(getenv('DRIVER_URL')) ? getenv('DRIVER_URL') : 'http://localhost:4444/wd/hub';
$seleniumHost = !empty(getenv('DRIVER_URL')) ? getenv('DRIVER_URL') : '"http://localhost:4444';

return new Selenium2Driver($browser, null, $seleniumHost);
}
Expand Down

0 comments on commit c15694b

Please sign in to comment.