W3c compat release

.github/workflows/tests.yml

@@ -5,8 +5,9 @@ on:
   pull_request:
   workflow_dispatch:
 
-env:
-  DRIVER_URL: "http://localhost:4444/wd/hub"
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
 
 defaults:
   run:
@@ -17,37 +18,47 @@ jobs:
     name: Check composer.json
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+
       - uses: shivammathur/setup-php@v2
         with:
           coverage: none
           php-version: '8.2'
+
       - run: composer validate --strict --no-check-lock
 
   static_analysis:
     name: Static analysis
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+
       - uses: shivammathur/setup-php@v2
         with:
           coverage: none
           php-version: '8.2'
+
       - name: Install dependencies
-        run: composer update --ansi --no-progress --prefer-dist --no-interaction
+        run: |
+          composer update --ansi --no-progress --prefer-dist --no-interaction
+
       - run: vendor/bin/phpstan analyze
 
   tests:
     name: Tests
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
+        php: [ '8.1', '8.2', '8.3' ]
+        # 2.53.1 - version the original package was using for tests
+        # 3 - last version of 3
+        # 4.1.2-20220227 - last known working version of 4 where the modifications to this package weren't needed
+        selenium: ['2.53.1', '3', '4.1.2', 'latest']
       fail-fast: false
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -71,7 +82,7 @@ jobs:
 
       - name: Start Selenium
         run: |
-          docker run --net host --name selenium --volume /dev/shm:/dev/shm --shm-size 2g selenium/standalone-firefox:2.53.1 &> ./logs/selenium.log &
+          docker run --net host --name selenium --volume /dev/shm:/dev/shm --volume $GITHUB_WORKSPACE:$GITHUB_WORKSPACE -e SE_NODE_OVERRIDE_MAX_SESSIONS=true -e SE_NODE_MAX_SESSIONS=5 --shm-size 2g selenium/standalone-firefox:${{ matrix.selenium }} &> ./logs/selenium.log &
 
       - name: Wait for browser & PHP to start
         run: |
@@ -80,7 +91,11 @@ jobs:
 
       - name: Run tests
         run: |
-          vendor/bin/phpunit -v --coverage-clover=coverage.xml
+          if [ "${{ matrix.selenium }}" == "latest" ] || [ "${{ matrix.selenium }}" == "4.1.2" ]; then
+            ./vendor/bin/phpunit -v --coverage-clover=coverage.xml
+          else
+            DRIVER_URL="http://localhost:4444/wd/hub" ./vendor/bin/phpunit -v --coverage-clover=coverage.xml
+          fi
 
       - name: Upload coverage
         uses: codecov/codecov-action@v2

CHANGELOG.md

@@ -1,13 +1,26 @@
-1.7.0 / 2023-02-26
+1.7.0 / 2023-12-09
 ==================
 
 BC break:
 
 * `syn` JS library was upgraded from v0.0.3 to v0.15.0
 
+New features:
+
+* Added parameter types for all methods
+* Added support for Symfony 7
+
 Bug fixes:
 
-* `Selenium2Driver::{keyPress, keyDown, keyUp}` methods were using numeric string input as char code. Newly an integer type must be passed.
+* Fix compatibility of `execute` with Selenium 4
+* `Selenium2Driver::{keyPress, keyDown, keyUp}` methods were using numeric string input as char code. Newly an integer type must be passed. Strings are not handled as strings properly, as done in other Mink drivers.
+* Add proper error handling for non-started sessions
+
+Testsuite:
+
+* Fixed compatibility with the latest driver testsuite
+* Added CI jobs for PHP 8.2 and 8.3
+* Added static analysis with phpstan
 
 1.6.0 / 2022-03-28
 ==================

composer.json

@@ -22,14 +22,14 @@
         "php": ">=7.2",
         "ext-json": "*",
         "behat/mink": "^1.11@dev",
-        "instaclick/php-webdriver": "^1.4.14"
+        "lullabot/php-webdriver": "^2.0"
     },
     "require-dev": {
         "mink/driver-testsuite": "dev-master",
         "phpstan/phpstan": "^1.10",
         "phpstan/phpstan-phpunit": "^1.3",
         "phpunit/phpunit": "^8.5.22 || ^9.5.11",
-        "symfony/error-handler": "^4.4 || ^5.0"
+        "symfony/error-handler": "^4.4 || ^5.0 || ^6.0 || ^7.0"
     },
 
     "autoload": {

phpstan.dist.neon

@@ -7,9 +7,6 @@ parameters:
     treatPhpDocTypesAsCertain: false
     ignoreErrors:
         - '#^Method Behat\\Mink\\Tests\\Driver\\Custom\\[^:]+Test(Case)?\:\:test\w*\(\) has no return type specified\.$#'
-        # instaclick/php-webdriver misses the @method for this magic method
-        - '#^Call to an undefined method WebDriver\\Session\:\:file\(\)\.$#'
-
 includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-phpunit/rules.neon

phpunit.xml.dist

@@ -10,6 +10,7 @@
 
     <php>
         <var name="driver_config_factory" value="Behat\Mink\Tests\Driver\Selenium2Config::getInstance" />
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak" />
 
         <!--server name="WEB_FIXTURES_HOST" value="http://test.mink.dev" /-->
         <!-- MacOS -->
@@ -18,7 +19,7 @@
         <!--<server name="WEB_FIXTURES_BROWSER" value="firefox"/>-->
 
         <!-- where driver will connect to -->
-        <server name="DRIVER_URL" value="http://localhost:4444/wd/hub" />
+        <!-- <server name="DRIVER_URL" value="http://localhost:4444" /> -->
 
         <!-- where DocumentRoot of 'Test Machine' is mounted to on 'Driver Machine' (only if these are 2 different machines) -->
         <!--server name="DRIVER_MACHINE_BASE_PATH" value="" /-->