Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort by title if the date matches #65

Merged
merged 2 commits into from
Sep 14, 2022
Merged

fix: Sort by title if the date matches #65

merged 2 commits into from
Sep 14, 2022

Conversation

deviantintegral
Copy link
Member

This fixes randomly changing the order of ADRs accepted on the same date on builds.

@e0ipso e0ipso temporarily deployed to Tugboat September 13, 2022 16:44 Destroyed
@e0ipso e0ipso temporarily deployed to Tugboat September 13, 2022 16:51 Destroyed
@deviantintegral
Copy link
Member Author

This is new:

UNHANDLED REJECTION ENOSPC: System limit for number of file watchers reached,
watch '/var/lib/tugboat/packages/example/gatsby-config.js'



  Error: ENOSPC: System limit for number of file watchers reached, watch '/var/l
  ib/tugboat/packages/example/gatsby-config.js'

@e0ipso e0ipso temporarily deployed to Tugboat September 13, 2022 17:10 Destroyed
@deviantintegral deviantintegral marked this pull request as ready for review September 13, 2022 17:52
@e0ipso e0ipso temporarily deployed to Tugboat September 13, 2022 17:52 Destroyed
@deviantintegral
Copy link
Member Author

@e0ipso there's no testing for this right now. If I add a record to the example directory, then it will show up in downstream sites too. Thoughts?

@e0ipso
Copy link
Member

e0ipso commented Sep 14, 2022

If I add a record to the example directory, then it will show up in downstream sites too. Thoughts?

I think that is not the case. The theme (/packages/gatsby-theme-adr) is independent from the example site (/packages/example).

What people download using npm is the theme. This is specified with the pkgRoot in semantic release.

@e0ipso
Copy link
Member

e0ipso commented Sep 14, 2022

I created #66 as a follow up. I think this PR is safe to merge since it follows the official documentation.

@e0ipso e0ipso merged commit 3002bac into main Sep 14, 2022
@e0ipso e0ipso deleted the 0-sort-title branch September 14, 2022 08:03
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants