Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73 short titles #77

Merged
merged 3 commits into from
Dec 11, 2024
Merged

73 short titles #77

merged 3 commits into from
Dec 11, 2024

Conversation

sirkitree
Copy link
Collaborator

Resolves #73

Add short titles for mobile/narrow viewports

  • Added shortTitle field to book metadata in index.html files
  • Updated .eleventy.js to include shortTitle in book collection data
  • Modified sidebar.liquid to display shortTitle with fallback to full title
  • Updated styles.scss to show shortTitle on narrow viewports (height <= 800px) and mobile (width <= 1440px)

This change improves readability of book titles in the sidebar when space is constrained, either due to narrow viewport height in desktop view or when the site switches to mobile layout. The shortTitle provides a more concise version while maintaining context.

@huntermacd
Copy link
Collaborator

Screenshot 2024-11-25 at 3 13 50 PM

Lookin' good, just need to make sure the short title visibility kicks in earlier.

@sirkitree
Copy link
Collaborator Author

Ok try that - increased from 800px to 920px

Copy link
Collaborator

@huntermacd huntermacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sirkitree sirkitree merged commit ebd72c0 into main Dec 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical title overflows on shorter screen heights
2 participants