Merge pull request #12 from alexpott/fix-php-version-testing

Fix PHP version testing
Lullabot · Jul 4, 2024 · cc9c601 · cc9c601
2 parents 7b37937 + e0ad52e
commit cc9c601
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/Tests.yml b/.github/workflows/Tests.yml
@@ -17,17 +17,22 @@ jobs:
 
     strategy:
       matrix:
-        php: [ '7.4', '8.0', '8.1', '8.2' ]
+        php: [ '8.0', '8.3' ]
       fail-fast: false
 
     steps:
       - uses: actions/checkout@v3
 
       - uses: ddev/github-action-setup-ddev@v1
+        with:
+          autostart: false
 
       - name: Setup PHP Version
         run: ddev config --php-version ${{ matrix.php }}
 
+      - name: Start ddev
+        run: ddev start
+
       - name: Install dependencies
         run: ddev composer install
 

diff --git a/composer.json b/composer.json
@@ -11,7 +11,8 @@
     "homepage": "https://www.lullabot.com/",
     "license": "Apache-2.0",
     "require": {
-        "ext-curl": "*"
+        "ext-curl": "*",
+        "php": ">=8.0.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^8.5 || ^9.5"

diff --git a/test/Test/WebDriver/ChromeDriverTest.php b/test/Test/WebDriver/ChromeDriverTest.php
@@ -37,6 +37,7 @@ class ChromeDriverTest extends WebDriverTestBase
 {
     protected $testWebDriverRootUrl = 'http://localhost:9515';
     protected $testWebDriverName    = 'chromedriver';
+    protected $status = null;
 
     protected function setUp(): void
     {

diff --git a/test/Test/WebDriver/GeckoDriverTest.php b/test/Test/WebDriver/GeckoDriverTest.php
@@ -37,6 +37,7 @@ class GeckoDriverTest extends WebDriverTestBase
 {
     protected $testWebDriverRootUrl = 'http://localhost:4444';
     protected $testWebDriverName    = 'geckodriver';
+    protected $status = null;
 
     protected function setUp(): void
     {