-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml, activate towncrier, update release workflow #211
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 12 -1
Lines 565 552 -13
=========================================
- Hits 565 552 -13 ☔ View full report in Codecov by Sentry. |
0a6a88d
to
fc4695e
Compare
1be48fa
to
e174403
Compare
58c923d
to
9bf3828
Compare
Can you try now after hyperspy/.github@c5376fc? |
Still trying to run |
OK, now I figured that I have to pass the ORGANISATION and it is running through :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks all good and working as expected.
I think that it should be possible to remove the MANIFEST.in
file.
- Do we need to change anything on the zenodo setup?
Not that I am aware of!
Is it worth updating the doc workflow? For example:
I see that the |
Which tokens? This is the workflow: |
I'll merge this PR and the doc workflow could become a new one. |
Description of the change
Migrate to
pyproject.toml
to replacesetup.py
(see e.g. Consolidate package metadata inpyproject.toml
, usesetuptools_scm
and add python 3.12 hyperspy/holospy#14)Activate towncrier for changelog (see e.g. Use towncrier and improve setting dev version hyperspy/holospy#17)
Update release workflow to match the one of HyperSpy and other extensions. Related todo:
Progress of the PR
upcoming_changes
,