Fix Holds resetting holdstarttime on every input

LumpBloom7 · Feb 21, 2024 · 0d748ab · 0d748ab
1 parent b7f5d66
commit 0d748ab
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/osu.Game.Rulesets.Sentakki/Objects/Drawables/DrawableHold.cs b/osu.Game.Rulesets.Sentakki/Objects/Drawables/DrawableHold.cs
@@ -200,6 +200,9 @@ protected override void ClearNestedHitObjects()
 
         private bool beginHoldAt(double timeOffset)
         {
+            if (HoldStartTime is not null)
+                return false;
+
             if (timeOffset < -Head.HitObject.HitWindows.WindowFor(HitResult.Miss))
                 return false;
 
@@ -225,15 +228,14 @@ public bool OnPressed(KeyBindingPressEvent<SentakkiAction> e)
             if (e.Action != SentakkiAction.Key1 + HitObject.Lane)
                 return false;
 
+            pressedCount++;
+
             if (beginHoldAt(Time.Current - Head.HitObject.StartTime))
             {
                 Head.UpdateResult();
                 NoteBody.FadeColour(AccentColour.Value, 50);
-            }
-
-            // Only the first input to this hitobject will be blocked
-            if (pressedCount++ == 0)
                 return true;
+            }
 
             // Passthrough excess inputs to later hitobjects in the same lane
             return false;