Add criticals to judgement chart

LumpBloom7 · Aug 24, 2024 · 406a445 · 406a445
1 parent 58c66b5
commit 406a445
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/osu.Game.Rulesets.Sentakki/Objects/Drawables/DrawableSentakkiJudgement.cs b/osu.Game.Rulesets.Sentakki/Objects/Drawables/DrawableSentakkiJudgement.cs
@@ -81,7 +81,7 @@ public DrawableSentakkiJudgement Apply(JudgementResult result, DrawableHitObject
                 if (result.Type == HitResult.Perfect)
                 {
                     timingPiece.Text = "CRITICAL";
-                    timingPiece.Colour = Color4.Orange;
+                    timingPiece.Colour = result.Type.GetColorForSentakkiResult();
                 }
                 else if (result.TimeOffset > 0)
                 {

diff --git a/osu.Game.Rulesets.Sentakki/SentakkiExtensions.cs b/osu.Game.Rulesets.Sentakki/SentakkiExtensions.cs
@@ -1,5 +1,6 @@
 using System;
 using osu.Framework.Extensions;
+using osu.Framework.Extensions.Color4Extensions;
 using osu.Game.Rulesets.Scoring;
 using osuTK;
 using osuTK.Graphics;
@@ -91,6 +92,7 @@ public static Color4 GetColorForSentakkiResult(this HitResult result)
             switch (result)
             {
                 case HitResult.Perfect:
+                    return Color4.Orange.Lighten(0.3f);
                 case HitResult.Great:
                     return Color4.Orange;
 

diff --git a/osu.Game.Rulesets.Sentakki/Statistics/ChartEntry.cs b/osu.Game.Rulesets.Sentakki/Statistics/ChartEntry.cs
@@ -183,6 +183,7 @@ public SimpleStatsSegment(IReadOnlyList<HitEvent> hitEvents)
                 addRatioBoxFor(HitResult.Ok);
                 addRatioBoxFor(HitResult.Good);
                 addRatioBoxFor(HitResult.Great);
+                addRatioBoxFor(HitResult.Perfect);
             }
 
             public void AnimateEntry()
@@ -210,6 +211,7 @@ private void addRatioBoxFor(HitResult result)
         public partial class DetailedStatsSegment : FillFlowContainer
         {
             private static readonly HitResult[] valid_results = new HitResult[]{
+                HitResult.Perfect,
                 HitResult.Great,
                 HitResult.Good,
                 HitResult.Ok,