Reintroduce timing dependent HoldTails #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially supercedes #569
This change makes it so that Hold notes return to having a timing-based result like in Maimai Finale, with a few leniencies carried over from DX.
Problem with DX (percentage-based) holds:
Advantages with DX holds
Solution introduced here
In a future "Classic/Finale mode" mod, HOLD recatching may be disabled, along with the automatic crit-perfect when holding past the end of the HOLD.