Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch system was broken #304

Merged
merged 3 commits into from
May 22, 2024
Merged

Torch system was broken #304

merged 3 commits into from
May 22, 2024

Conversation

Luthaf
Copy link
Owner

@Luthaf Luthaf commented May 17, 2024

Thanks to @PicoCentauri and @frostedoyster for finding these bugs!


📚 Documentation preview 📚: https://rascaline--304.org.readthedocs.build/en/304/

Copy link

github-actions bot commented May 17, 2024

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

Copy link
Collaborator

@frostedoyster frostedoyster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests?

@Luthaf
Copy link
Owner Author

Luthaf commented May 17, 2024

No, I'll add something. You can pull from this branch for testing purposes in the mean time!

@PicoCentauri
Copy link
Collaborator

Nice thanks. I will try next week!

@Luthaf
Copy link
Owner Author

Luthaf commented May 21, 2024

Now with tests as well

@Luthaf Luthaf merged commit 5348132 into master May 22, 2024
25 checks passed
@Luthaf Luthaf deleted the torch-system-was-broken branch May 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants