Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebasing system-with-data onto main #339

Closed

Conversation

liam-o-marsh
Copy link
Contributor

@liam-o-marsh liam-o-marsh commented Oct 31, 2024


📚 Documentation preview 📚: https://rascaline--339.org.readthedocs.build/en/339/

@liam-o-marsh liam-o-marsh changed the title rebasing this branch onto main rebasing system-with-data onto main Oct 31, 2024
@liam-o-marsh
Copy link
Contributor Author

honestly having this be a merge proper is a bad idea, since my version is already a rebase
it is probably better to resolve this out-of-band, if you have the time for it
or not at all, if you don't want to merge system-with-data into main without my bond-centered stuff to use it

@Luthaf
Copy link
Owner

Luthaf commented Nov 1, 2024

I can do a quick rebase of this branch! For the bond-centered descriptor, I am finally able to spend some time working on rascaline, so after #328 is merged my next priority will be making a proper release of the code (#284). At the same time/after this, we could try again to update the bond-centered descriptor to the new hyper schema & merge it.

Since the last time we chatted about it, was this descriptor used in a scientific paper? It would push it a couple of steps up in my TODO list!

@Luthaf
Copy link
Owner

Luthaf commented Nov 1, 2024

Ok, the branch has been rebased, and also includes #338.

@liam-o-marsh
Copy link
Contributor Author

thanks!

At the same time/after this, we could try again to update the bond-centered descriptor to the new hyper schema & merge it.
Since the last time we chatted about it, was this descriptor used in a scientific paper? It would push it a couple of steps up in my TODO list!

Definitely later, that project became too big to be a single publication, and somehow actual bond-centered descriptions are way up in the dependency chain between papers
The main reason why I'm looking at rascaline again is because Joe told me about a bunch of changes that would be interesting, so I'm trying to slowly rebase my copy of it (which has a bunch of changes, both unmerged and not upstreamed at all)

@Luthaf Luthaf deleted the system-with-data branch November 1, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants