refactor: findDatesWithTodosByMonth() 메서드에서 addAll() 메서드 대신 생성자 호출 사용

MADA-UMC · May 9, 2024 · 9dda369 · 9dda369
1 parent 2d62148
commit 9dda369
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/main/java/com/umc/mada/todo/service/ChartService.java b/src/main/java/com/umc/mada/todo/service/ChartService.java
@@ -107,18 +107,16 @@ public StatisticsResponseDto monthlyStatistics(Authentication authentication, Lo
 
     public Map<String, Object> findDatesWithTodosByMonth(Authentication authentication, YearMonth yearMonth) {
         User user = userRepository.findByAuthId(authentication.getName()).orElseThrow(()-> new RuntimeException("올바른 유저 ID가 아닙니다."));
-        Set<Integer> datesWithTodosSet = new HashSet<>();
 
         // 투두
-        List<Integer> todoDates = todoRepository.findDistinctDaysByUserIdAndYearMonth(user.getId(), yearMonth.toString());
-        datesWithTodosSet.addAll(todoDates);
+        Set<Integer> datesWithTodosSet = new HashSet<>(todoRepository.findDistinctDaysByUserIdAndYearMonth(user.getId(), yearMonth.toString()));
 
         // 반복 투두
-        List<Integer> recurringTodoDates = repeatTodoRepository.findDistinctDaysByUserIdAndYearMonth(user.getId(), yearMonth.toString());
-        datesWithTodosSet.addAll(recurringTodoDates);
+        datesWithTodosSet.addAll(repeatTodoRepository.findDistinctDaysByUserIdAndYearMonth(user.getId(), yearMonth.toString()));
 
         List<Integer> datesWithTodos = new ArrayList<>(datesWithTodosSet);
         Collections.sort(datesWithTodos);
+
         Map<String, Object> map = new LinkedHashMap<>();
         Map<String, Object> data = new LinkedHashMap<>();
         data.put("datesWithTodos", datesWithTodos);