Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed text colour in mobile view #451

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Fixed text colour in mobile view #451

merged 3 commits into from
Jul 1, 2024

Conversation

dhairyagothi
Copy link
Contributor

#436

Description

fixed text of navbar items colour

before
image

After

image

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nestondc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 11:44am
nestondcshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 11:44am

@dhairyagothi
Copy link
Contributor Author

@dinxsh please check and merge PR under GSSOC'24

dinxsh
dinxsh requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly make the parent text color white too here fashion to match the others looks

@dhairyagothi
Copy link
Contributor Author

okay sure

@dhairyagothi
Copy link
Contributor Author

image

@dinxsh check now

@dinxsh dinxsh added GSSoC'24 Under GirlScript Summer of code level2 medium gssoc Under GirlScript Summer of code labels Jul 1, 2024
dinxsh
dinxsh approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinxsh dinxsh merged commit 2c00975 into MAVRICK-1:dev Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinxsh dinxsh dinxsh approved these changes

Assignees

@dhairyagothi dhairyagothi

Labels
gssoc Under GirlScript Summer of code GSSoC'24 Under GirlScript Summer of code level2 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhairyagothi @dinxsh