Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: About us Not able to scroll bug #447 #459

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

nishant0708
Copy link
Contributor

-fixed about us not able to scroll issue

[Feature Request]: About us Not able to scroll bug #447

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

marverik-scrool-about.mp4

Types of changes

  • [ y] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ y] My code follows the code style of this project.
  • [y] My change requires a change to the documentation.
  • [ y] I have updated the documentation accordingly.

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nestondc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 11:33pm
nestondcshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 11:33pm

@nishant0708
Copy link
Contributor Author

hen @dinxsh can you review this pr

@dinxsh
Copy link
Collaborator

dinxsh commented Jul 1, 2024

2 word pr? really? @nishant0708

@dinxsh dinxsh closed this Jul 1, 2024
@nishant0708
Copy link
Contributor Author

nishant0708 commented Jul 2, 2024

2 word pr? really? @nishant0708

It just get solved in that only 😂 bro you could have merged it and not assigned any labels to it. Sorry for the trouble mam @dinxsh

@dinxsh
Copy link
Collaborator

dinxsh commented Jul 2, 2024

closed since the about us scroll works for me. no worries though there are always other issues @nishant0708

@nishant0708
Copy link
Contributor Author

hey @dinxsh see in about us there is a issue whenever the state of component changes it just scroll backs to top . See checkit
go to about scroll down and hover on any card it will scroll you to top to fix that just in useeffect( ( ) , [ ] ) just add this array in useeffect it will be fine . its just bugging me so fix it from you end

@dinxsh
Copy link
Collaborator

dinxsh commented Jul 2, 2024

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

@dinxsh dinxsh reopened this Jul 2, 2024
@dinxsh dinxsh merged commit f457c2a into MAVRICK-1:dev Jul 2, 2024
5 checks passed
@nishant0708
Copy link
Contributor Author

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

It is happening in local host

@dinxsh
Copy link
Collaborator

dinxsh commented Jul 2, 2024

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

It is happening in local host

do pull the new merged changes to fix then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants