-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Want to Fix Card Design when we search products And ITS WORKING AS WELL #448 #465
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey @dinxsh please review this pr i have ensured every component of search product should perform same functionality that home page did |
Hey @dinxsh can you review this pr please |
{filteredProducts.length > 0 ? ( | ||
filteredProducts.map((product) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason behind removing all these code? contains icons like star and favorite that you removed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dinxsh basically it was a design of a card component but we already have designed one product component so we should use this component so that there is uniformity among cards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want I could comment them but they are not needed any more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @dinxsh can you please review this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah alright, could you just add that heart icon back then? @nishant0708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @dinxsh i checked
there is already heart icon present so i guess we dont need to add another one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @dinxsh please add labels and assign it to me |
Hey @dinxsh @sanket95droid please add labels toh this pr |
@nishant0708 Done, nice work. |
[Feature Request]: Want to Fix Card Design when we search products And ITS WORKING AS WELL #448
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: