Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Want to improve Signup Signin Cards Ui #466 #493

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Feature Request]: Want to improve Signup Signin Cards Ui #466 #493

merged 1 commit into from
Jul 23, 2024

Conversation

nishant0708
Copy link
Contributor

Description

Fixed Cards Ui #466

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2024-07-23 010858
Screenshot 2024-07-23 010906

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X ] My code follows the code style of this project.
  • [ X] My change requires a change to the documentation.
  • [ X] I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nestondc ❌ Failed (Inspect) Jul 22, 2024 7:45pm
nestondcshop ❌ Failed (Inspect) Jul 22, 2024 7:45pm

@nishant0708
Copy link
Contributor Author

hey @sanket95droid @dinxsh can you review this pr

dinxsh
dinxsh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good job!

@dinxsh dinxsh merged commit a970e48 into MAVRICK-1:dev Jul 23, 2024
2 of 4 checks passed
@nishant0708
Copy link
Contributor Author

Hey @dinxsh can you add level and gssoc labels toh this and assign it to me as well please

@dinxsh dinxsh added GSSoC'24 Under GirlScript Summer of code level2 medium gssoc Under GirlScript Summer of code labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinxsh dinxsh dinxsh approved these changes

Assignees

@nishant0708 nishant0708

Labels
gssoc Under GirlScript Summer of code GSSoC'24 Under GirlScript Summer of code level2 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishant0708 @dinxsh