Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helanal MDAKit #224

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add helanal MDAKit #224

merged 1 commit into from
Nov 15, 2024

Conversation

fiona-naughton
Copy link
Contributor

Adding the helanal MDAkit for analysis of protein helix structure, adapted from the helix_analysis currently in MDAnalysis.

It's up on PyPI; I'm also attempting to get it on conda-forge which has stalled for now, but not needed to get this kit registered.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - just the one question.

Please do remember to update the registry entry when the conda-forge recipe has been uploaded.


import_name: helanal

python_requires: ">=3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match your conda-forge recipe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that catch - I've updated it to 3.10 on the conda-forge recipe

@orbeckst
Copy link
Member

Can we merge this?

@IAlibay IAlibay merged commit 9d3b0b6 into main Nov 15, 2024
5 checks passed
@IAlibay IAlibay deleted the add-helanal branch November 15, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants