Update channels to be more specific #143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
reviewed
Nov 16, 2024
| @@ -1,20 +1,22 @@ | |||
| name: {{cookiecutter.repo_name}}-test | |||
| channels:{% if cookiecutter.dependency_source == 'Prefer conda-forge over the default anaconda channel with pip fallback' %} | |||
| - conda-forge{% endif %} | |||
| channels:{% if cookiecutter.__dependency_source == 'anaconda' %} | |||
There was a problem hiding this comment.
If I'm understanding this properly, if this case happens then the channel will be set to default and won't have conda-forge? If that's the case, they won't be able to download MDAnalysis so it stops being an mdakit.
There was a problem hiding this comment.
Good catch. I had been going to move MDA to the pip downloads but hadn't yet -- firstly need to figure out how to test this 😅
There was a problem hiding this comment.
I'm not sure that offering the combination of a mixed pip + conda install is a good idea. i.e. it's what I would consider bad practice.
AFAIK there are nearly no cases where one has something in defaults that isn't in conda-forge - why even keep it around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Changes made in this Pull Request:
PR Checklist