Artifact object update #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h type attributes - A change to adopt the same logic as file objects regarding the different hash values - In STIX 2.1 an Artifact object is not necessarily linked to a File object and both referenced by an Observed Data object. In some cases Artifact objects are referenced for instance by Malware objects, in which case they describe the actual malware sample. It is then usefull to have the different hash values in single attributes rather than concatenated in a text attribute
|
Oh wait, should I still keep the hashes attributes? Maybe I should, and we have both for the 2 different use cases |
|
I think it's fine. Maybe we should adapt the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I agree the
hashesattribute, where we could concatenate all the hash types and values in a single text, made sense in the use we had of this object template - which was mostly to be referenced by afileobject which already has each single hash value - it is now different when we import an Artifact as described in the STIX 2.1 definition of a malware sample.In this case the artifact can be a standalone object, and it is more appropriate to extract the hash values separately