Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenTIDE Object #446

Closed
wants to merge 7 commits into from

Conversation

signaledge
Copy link
Contributor

  • Adds a version attribute, to describe the version of the OpenTIDE object itself. Default value of 1.
  • Re-orders the UI Priority, so that the object name appears first, then uuid, version, opentide-type, then opentide-object
  • Make name a required value
  • Update the README object listing to contain an entry for opentide

@adulau
Copy link
Member

adulau commented Nov 13, 2024

Thank you. Can you run jq_all_the_things.sh and update the PR to make the JSON in the sorted format?

@signaledge
Copy link
Contributor Author

@adulau Sure - I just ran it, could you check if it's the expected format as I can't see changes (I tried it twice) ?

@signaledge
Copy link
Contributor Author

@adulau We have updated the MISP object with a new opentide-relation attribute, which should allow to leverage the MISP Object correlation feature to interrelate these OpenTIDE Object in a connection tree, without necessarily rebuilding the full knowledge graph.

@adulau
Copy link
Member

adulau commented Nov 30, 2024

Can you fix to make the tests pass?

https://github.com/MISP/misp-objects/actions/runs/12082829665/job/33694725088

@signaledge
Copy link
Contributor Author

@adulau The file was properly JQed, but somehow the README changes broke the tests when I test locally ./validate_all.sh properly runs on my local environment. I tried removing the README here, and also opening #447 directly without the README but this also failed. Running ./jq_all_the_things.sh did not change the file.

image

@remid0c
Copy link

remid0c commented Dec 10, 2024

Hi @signaledge @adulau I am a bit confused on the test failure as there is no error on the local clone used for the PR afaik. what to do?

@adulau
Copy link
Member

adulau commented Dec 15, 2024

Thank you for the PR. It's merged and fixed e4f09c5 ;-)

@adulau adulau closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants