-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OpenTIDE Object #446
Conversation
signaledge
commented
Nov 12, 2024
- Adds a version attribute, to describe the version of the OpenTIDE object itself. Default value of 1.
- Re-orders the UI Priority, so that the object name appears first, then uuid, version, opentide-type, then opentide-object
- Make name a required value
- Update the README object listing to contain an entry for opentide
Thank you. Can you run |
@adulau Sure - I just ran it, could you check if it's the expected format as I can't see changes (I tried it twice) ? |
@adulau We have updated the MISP object with a new opentide-relation attribute, which should allow to leverage the MISP Object correlation feature to interrelate these OpenTIDE Object in a connection tree, without necessarily rebuilding the full knowledge graph. |
Can you fix to make the tests pass? https://github.com/MISP/misp-objects/actions/runs/12082829665/job/33694725088 |
@adulau The file was properly JQed, but somehow the README changes broke the tests when I test locally ./validate_all.sh properly runs on my local environment. I tried removing the README here, and also opening #447 directly without the README but this also failed. Running ./jq_all_the_things.sh did not change the file. |
Hi @signaledge @adulau I am a bit confused on the test failure as there is no error on the local clone used for the PR afaik. what to do? |
Thank you for the PR. It's merged and fixed e4f09c5 ;-) |