Generalized propulsion functions #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 73.42% 73.53% +0.10%
==========================================
Files 78 81 +3
Lines 13671 13733 +62
==========================================
+ Hits 10038 10098 +60
- Misses 3633 3635 +2 ☔ View full report in Codecov by Sentry. |
removed HXs array from wsize
ngomezve
force-pushed
the
dev_generalprop
branch
from
9b71179 to
7b2196d
Compare
askprash
reviewed
Jan 25, 2025
src/mission/mission.jl
Outdated
| #Unpack aircraft | ||
| pari, parg, parm, para, pare, fuse, fuse_tank, wing, htail, vtail = unpack_ac(ac, imission) | ||
| #Engine model | ||
| enginecalc!, _ = extract_engine_model(ac.engine) |
There was a problem hiding this comment.
we could access all of this directly with engine.enginecalc! with the suggested changes
|
I made the changes suggested by @askprash. The code is still somewhat slower and with more allocations than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new engine functions:
enginecalc!andengineweight!that replace the engine function calls. These functions act as handles for any propulsion function that can use the same syntax, e.g., do design or off-design cases.The
enginecalc!andengineweight!functions are stored and then extracted from a newEngineobject produced when the input file is read. The user is free to then replace those functions with others if a more custom propulsion option is desired.The old turbofan functions are now stored in a dedicated
turbofanfolder insidesrc/engine. New functions calledtfwrap!andtfweightwrap!have been created as wrappers for the old functions and related pieces of code, such that these can be called by the generalized functions.