Remove the ArchivedProject model. #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This just needs MIGRATE_AFTER_INSTALL=True. Unfortunately after I tried to fix loaddemo in #2297, it's now broken in a different weird way. :/ |
tompollard
force-pushed
the
tp/rm_archivedproject
branch
from
850546e
to
9212922
Compare
Thanks, now added.
That explains the error I was getting yesterday after trying to run |
tompollard
force-pushed
the
tp/rm_archivedproject
branch
from
9212922
to
a4e1376
Compare
tompollard
added a commit
that referenced
this pull request
Sep 25, 2024
We use `.gitkeep` files as placeholders for "empty" directories. For example we have two demo active projects that don't contain any files, and we want the `loaddemo` command to create project directories for them. However, `loaddemo` (or `TestMixin`, which loads the demo files for the test suite) shouldn't create an actual `.gitkeep` file in the project directory. Additionally, `loaddemo` shouldn't fail if the demo project directory already exists. Should fix problems with `test-upgrade.sh` as seen in #2303.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the unused
ArchivedProjectmodel.We now track the "Archived" status of projects on the ActiveProject model (see: #2149).
In #2170 we migrated all ArchivedProject content to ActiveProjects.