-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CKEditor to TinyMCE #2324
base: dev
Are you sure you want to change the base?
CKEditor to TinyMCE #2324
Conversation
This breaks badly in old browsers: using Firefox 78, the editor mostly seems to work, but upon trying to save the form it crashes (which the user won't notice unless they are watching the console) and apparently submits blank content. tinymce/tinymce#9557 |
Can we raise a warning for people with old browsers or would you prefer to explore alternatives? From googling, the latest version of CKEditor is popular (though I'm sure it has its own issues). |
I'm certainly willing to look at alternatives & that's part of why I wanted to post this as a preview. But it also should be possible to add a workaround (my thought was to fall back to a plain textarea on old unsupported browsers.) |
Personally I'd rather just ask people using outdated browsers to update them! |
As we've discussed, PhysioNet's current rich text editor (CKEditor 4) is unmaintained and should be replaced. This branch replaces
django-ckeditor
withdjango-tinymce
(https://github.com/jazzband/django-tinymce).Further work is still needed, but it should be usable at this point, so I invite folks to try this branch out and see what you think of the UI. TinyMCE (like CKEditor) is highly customizable, so this is a good opportunity to point out anything you dislike about the toolbar, menus, keyboard shortcuts, look and feel, etc.