Add vendor name #223
Merged
Add vendor name #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Stakeholders requested that the vendor name be added to the credit card slips email How this addresses that need: * Update extract_credit_card_slip_data function to include vendor name * Add vendor name to XML template * Update PR template * Update fixtures and unit tests to account for code changes Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/INFRA-439
Pull Request Test Coverage Report for Build 9084172256Details
💛 - Coveralls |
ghukill
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Updating the app to include the vendor name in the HTML output that is emailed to acquisitions staff. This change was already reviewed and approved by stakeholders in Technical Services.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)