Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1324

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Update dependencies #1324

merged 1 commit into from
Jun 28, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Jun 28, 2024

Note that this excludes sqlite3, which Rails does not yet support (but probably will in the next release). See MITLibraries/tacos#42 for details.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

@mitlib mitlib temporarily deployed to mit-bento-pr-1324 June 28, 2024 16:35 Inactive
@jazairi jazairi force-pushed the update-dependencies branch from 8c13959 to e4448ba Compare June 28, 2024 16:35
@jazairi jazairi had a problem deploying to mit-bento-pr-1324 June 28, 2024 16:35 Failure
@coveralls
Copy link

Coverage Status

coverage: 99.216%. remained the same
when pulling e4448ba on update-dependencies
into e1318ec on main.

@jazairi jazairi force-pushed the update-dependencies branch from e4448ba to 8beb96c Compare June 28, 2024 16:42
@jazairi jazairi temporarily deployed to mit-bento-pr-1324 June 28, 2024 16:42 Inactive
@coveralls
Copy link

Coverage Status

coverage: 99.216%. remained the same
when pulling 8beb96c on update-dependencies
into e1318ec on main.

@jazairi jazairi merged commit eb228b0 into main Jun 28, 2024
4 checks passed
@jazairi jazairi deleted the update-dependencies branch June 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants