Updates WordPress Coding Standards #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * release versions of wpcs do not support PHP 8+ * the 3.0 release of wpcs will support PHP 8+, but has no timeline to an official release other than "when it is ready" * as this is just a development dependency, there is minimal risk to updating to the development branch How does this address that need: * updates to the dev-develop branch of wpcs * adds a `phpcs` option in composer to allow calling `phpcs` as installed by composer without having to install it globally * `composer phpcs FILENAME` will now work Document any side effects to this change: * `phpcs.security.xml` was updated to ignore a few things that were now returning that weren't before (I think the plan for wpcs is to move a lot to a utlity php library so the changes are likely coming from that in-progress work) * I updated one file that was now flagged in the security check as it was an auto-fixable problem rather than flagging it as non-security
matt-bernhardt
pushed a commit
that referenced
this pull request
Jul 7, 2023
This is copy pasta from Drupal Composer Managed. While the same changes were made to WordPress Composer Managed (in terms of the `upstream-require` script), the readme was not moved over.
|
Closing in favor of #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
How does this address that need:
phpcsoption in composer to allow callingphpcsas installed by composer without having to install it globallycomposer phpcs FILENAMEwill now workDocument any side effects to this change:
phpcs.security.xmlwas updated to ignore a few things that were now returning that weren't before (I think the plan for wpcs is to move a lot to a utlity php library so the changes are likely coming from that in-progress work)Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES dependencies are updated
Code Reviewer
(not just this pull request message)