Update CI workflow #167
Merged
Update CI workflow #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: Github will be retiring actions/cache@v2 at the start of February 2025, which this repository is currently configured to use. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/pw-125 ** How does this address that need: This updates our CI workflow to use actions/cache@v4, which is the latest release. No other changes appear to be needed beyond a version bump. ** Document any side effects to this change: None
** Why are these changes being introduced: There are a few other regular maintenance changes that we should make to our CI workflow: - actions/checkout should move from v2 to v4 - Our use of a set-output command is going to be deprecated, and a new syntax is available (and has been adopted by the Bedrock project which we are following) - PHP 8.4 has been released by that community, so we should be checking our network against that release ** Relevant ticket(s): n/a for these changes, but I'm still grouping them under PW-125 ** How does this address that need: Each of the bullets above has been addressed: - actions/checkout has been upgraded from v2 to v4 - The set-output syntax is removed in favor of the environment files, per https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Each of the above changes is made to match what the Bedrock project is doing. - PHP 8.4 is added to our support matrix Bedrock has not yet added PHP 8.4 to their support matrix, but this feels like a justifiable change to make on our own. ** Document any side effects to this change: None
JPrevost
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to our CI workflow. One is prompted by an imminent retirement, while the others are changes of convenience, given that we're touching the file at all.
The required change is to upgrade our use of actions/cache from v2 to v4. V2 will be retired in a few weeks, so we need to upgrade now or risk not being able to deploy the network. From testing on Github so far, it looks like there are no related changes to this upgrade - our current parameters and arguments continue to work.
The optional changes are:
Upgrading actions/checkout from v2 to v4 (also the latest available release). We have not been advised about any requirement to make this change.
Updating the syntax in one of our CI steps to move from
set-outputto a syntax using environment files. This has been showing up in our CI output for a while as a needed change, but Github has been holding off on requiring the change. More details can be found at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Adding PHP 8.4 to the list of our tested language versions. We are currently using PHP 8.1 on Pantheon, with no immediate plans to move to 8.4 for a while, but having this output now should be helpful as we plan for the future.
Ticket: https://mitlibraries.atlassian.net/browse/PW-125
Developer
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)