IN 1038 - handle more base RequestException #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: A harvest recently failed when the requests library threw a ConnectTimeout exception. We were formerly handling only HTTPErrors, which this exception did not inherit from. This exception aborted the harvest instead of gracefully skipping and reporting record, and continuing. How this addresses that need: * OAIClient.get_records() now catches more base RequestException which includes HTTP and connection errors Side effects of this change: * Connection errors when retrieving a record will be logged and skipped, and will not fail the full harvest. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1038
Pull Request Test Coverage Report for Build 10494632383Details
💛 - Coveralls |
ehanson8
approved these changes
Aug 22, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| "request_lib_exception", | ||
| [ConnectTimeout, HTTPError], |
jonavellecuerdo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
A harvest recently failed (Sentry error) when the requests library threw a
ConnectTimeoutexception. We were formerly handling onlyHTTPError's, which this exception did not inherit from. This exception aborted the harvest instead of gracefully skipping and reporting record, and continuing.How this addresses that need:
OAIClient.get_records()now catches more baseRequestExceptionwhich includes HTTP and connection errorsNOTE: with dependencies updated, it looks as pre-commit and/or linting has reformatted all the VCR cassette YAML files. Other than reformatting, they were not changed in this commit.
How can a reviewer manually see the effects of these changes?
The newly created test
test_get_records_handles_requests_lib_errorsdemonstrates handling of bothHTTPErrorandConnectTimeoutwhen thrown by requests library.Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)