Skip to content

Commit

Permalink
fixup validate_issn docs
Browse files Browse the repository at this point in the history
  • Loading branch information
JPrevost committed Nov 17, 2023
1 parent 8953d13 commit 306c72e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions app/models/standard_identifiers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@ def strip_invalid_issns
end

def validate_issn(candidate)
# This model is only called when the regex for an ISSN has indicated an ISSN
# This method is only called when the regex for an ISSN has indicated an ISSN
# of sufficient format is present - but the regex does not attempt to
# validate that the check digit in the ISSN spec is correct. This method
# does that calculation, so we can avoid sending nonsense requests to
# CrossRef or the Primo API for facially-valid ISSNs that actually are not,
# does that calculation, so we do not returned falsely detected ISSNs,
# like "2015-2019".
#
# The algorithm is defined at
Expand Down

0 comments on commit 306c72e

Please sign in to comment.