Code review feedback 2

Implement cassette scrubbing for cookie values None of these values are currently sensitive, but the possibility exists that future cassettes could store sensitive values in the Set-Cookie headers.
MITLibraries · Jan 13, 2025 · 4bfd7fa · 4bfd7fa
1 parent c8d8a25
commit 4bfd7fa
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 41 deletions.
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -17,6 +17,13 @@
 VCR.configure do |config|
   config.cassette_library_dir = 'test/vcr_cassettes'
   config.hook_into :webmock
+
+  config.before_record do |interaction|
+    header = interaction.response&.headers&.[]('Set-Cookie')
+    header&.each do |redacted_text|
+      interaction.filter!(redacted_text, '<FAKE_COOKIE_DATA>')
+    end
+  end
 end
 
 module ActionDispatch

diff --git a/test/vcr_cassettes/barcode_39080027236626.yml b/test/vcr_cassettes/barcode_39080027236626.yml
diff --git a/test/vcr_cassettes/barcode_not_found.yml b/test/vcr_cassettes/barcode_not_found.yml
diff --git a/test/vcr_cassettes/pmid_37953305.yml b/test/vcr_cassettes/pmid_37953305.yml
diff --git a/test/vcr_cassettes/pmid_not_found.yml b/test/vcr_cassettes/pmid_not_found.yml